3/10/16
Name of Reviewer:
Functionality
Data validations function properly
Component functions properly (Create, Read, Update, Delete)
Component enforces the proper business rules
Errors are raised to the caller
Proper encoding/decoding of XML strings (XML reserved chars.)
Mod files are utilized for common functions
Database rollbacks occur when errors are encountered
Parameter Objects: direction set in VB matches that of the stored proc
Sign-Off - Date -
Code QA Checklist
Reviewed
N/A Pass by
Comments
Developer
Variables are declared within subroutines or functions only (no global variables)
Sign-Off - Date -
Final Sign-Off and Approval
Name of COM-
Date-
Sign-Off-
Functionality
Stored procedures function properly (Create, Read, Update, Delete)
Errors being raised to caller
Parameter direction in stored proc matches that of VB parameter object
Sign-Off - Date -
Code QA Checklist
Reviewed
N/A Pass by
Comments
Developer
Sign-Off - Date -
Final Sign-Off and Approval
Name of PKG-
Date-
Sign-Off-
Name of Reviewer:
Functionality
Enforces the proper business rules
Produces the proper output file
Batch log file updated
Executable shuts down properly after termination
Database rollbacks occur when errors are encountered
Proper encoding/decoding of XML strings (XML reserved chars.)
Parameter Objects: direction set in VB matches that of the stored proc
Sign-Off - Date -
Code QA Checklist
Reviewed
N/A Pass by
Comments
Developer
Sign-Off - Date -
Final Sign-Off and Approval
Name of EXE-
Date-
Sign-Off-
Name of Reviewer:
Layout
Verify that Correct page title is displayed below header and in Browser window
Sign-Off - Date -
Code QA Checklist
Reviewed
N/A Pass by
Comments
Developer
Variables are declared within subroutines or functions only (no global variables)
Sign-Off - Date -
Final Sign-Off and Approval
Name of ASP-
Date-
Sign-Off-
All Procedures and functions should begin with a brief comment describing the
functional characteristics of the procedure. This description should not describe
the implementation details, because often these change over time, resulting in
Ensure that Comments are present to describe all functions
unnecessary comment maintenance work, or worse yet, an erroneous comment.
The code itself and any necessary inline comments will describe the
implementation.
Ensure that commented/dead code is cleaned Ensure that commented and dead code is cleaned and deleted.
Proper Indentation in multiples of four spaces should be followed while coding for
Ensure that tabbing/white spaces is used consistently
legibility and flow of script.
Turn on 'OPTION EXPLICIT'. In VB and VBScript you can use a variable without
explicitly declaring it. Turning on this option helps identify undefined variables -
which may well be typos - and helps increase performance. Undeclared local
Option Explicit used variables are slow, because the entire namespace must be searched to see if the
variable exists before it is created. Get rid of them. Make everything explicit. It's
good practice, it may trap typos, and it is faster. Look for <Option Explicit = True>
in the beginning of every ASP or COM.
Proper project references exists; unused references removed Make sure that old references (i.e. data env) are removed.
Early binding is used for objects where possible
Also, this way you can move classes to different or multiple DLLs and only need to
update the Object Factory COM component. In addition, if some object needs to
participate in a transaction only sometimes, it can be controlled by having 2 object
factories, one which requires transaction and other which disables them .
Also, this way you can move classes to different or multiple DLLs and only need to
update the Object Factory COM component. In addition, if some object needs to
participate in a transaction only sometimes, it can be controlled by having 2 object
factories, one which requires transaction and other which disables them .
Code passes NuMega Code Review evaluation Make sure that Code is run through NuMega and approved by the Numega lead.
Memory Description/Instruction
Ensure correct use of Object Context
Do not declare a variable, set it =something (instantiate) and then not use it in
Avoid instantiating objects that are never used in method
method.
Ensure that all ADO objects use .close before set = nothing Make sure all ADO objects have a .close before they are set=nothing.
Other Description/Instruction
Program specification document updated Please check COM specs to make sure they include new or updated functionality.
Program specification document updated Please check COM specs to make sure they include new or updated functionality.
Turn on 'OPTION EXPLICIT'. In VB and VBScript you can use a variable without
explicitly declaring it. Turning on this option helps identify undefined variables -
which may well be typos - and helps increase performance. Undeclared local
Option Explicit used
variables are slow because the entire namespace must be searched to see if the
variable exists before it is created. Get rid of them. Make everything explicit. It's
good practice, it may trap typos, and it is faster.
Proper project references exists; unused references removed Make sure that old references (i.e. data env) are removed.
Refer to COM+ Standards and Guidelines and follow COM+ standards of naming
Functions/Subroutines properly commented
variables.
Program specification document updated Please check COM specs to make sure they include new or updated functionality.
All Procedures and functions should begin with a brief comment describing the
functional characteristics of the procedure. This description should not describe
the implementation details, because often these change over time, resulting in
Ensure that Comments are present to describe all functions
unnecessary comment maintenance work, or worse yet, an erroneous comment.
The code itself and any necessary inline comments will describe the
implementation.
Any object instances should explicitly destroyed after they are done being used.
For instance, if you have a recordset object, make sure you always call:
There should be a MAXLENGTH property set on every text box. You can test this
Maxlength property set on all textbox controls criterion by entering as much data as you can through the front end and then
submit the form. This should not cause any errors.
Each 'Open' has a 'Close' for Recordset and Connection
Each recordset and Connection object that is open should be closed.
Objects
Local variables are those declared within subroutines and functions. Within a
Variables are declared within subroutines or functions only (no function or subroutine, local variable access is faster than global variable access.
global variables) Use of local variables also tends to make code cleaner, so use them when you
can.
Performance techniques followed where possible
Proper Indentation in multiples of four spaces should be followed while coding for
Code is readable and easy to follow (proper indentation, etc.)
legibility and flow of script.
Ensure that explicit Request Object properties are used (i.e.
.form)
Performance Description/Instruction
Avoid multi-variable Dim statements in ASP Only one variable per line; No Dim x,y,z As X.
Other Description/Instruction
Program specification document updated Please check COM specs to make sure they include new or updated functionality.